Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add sections to room header and user infos menus with menuV2 #29780

Merged
merged 78 commits into from
Aug 18, 2023

Conversation

guijun13
Copy link
Contributor

@guijun13 guijun13 commented Jul 11, 2023

Proposed changes (including videos or screenshots)

Modified

  • Room header
  • User card
  • User info
  • User menu on the room members list

menus to menuV2 implementation to separate the items into sections

Room header

/views/room/Header/RoomToolbox/RoomToolbox.tsx
Group 27 (1)

User card

/views/room/UserCard/UserCardWithData.tsx
Group 23

User info

/views/room/contextualBar/UserInfo/UserInfoActions.tsx
Group 20

User menu on members list

apps/meteor/client/views/room/contextualBar/RoomMembers/RoomMembersActions.tsx
Group 24

Issue(s)

Closes #25147

Steps to test or reproduce

Further comments

https://rocketchat.atlassian.net/browse/TC-811

@changeset-bot
Copy link

changeset-bot bot commented Jul 11, 2023

🦋 Changeset detected

Latest commit: 794b904

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 29 packages
Name Type
@rocket.chat/meteor Patch
@rocket.chat/core-typings Patch
@rocket.chat/rest-typings Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/gazzodown Patch
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/api-client Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/ddp-client Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/models Patch
@rocket.chat/ui-client Patch
@rocket.chat/ui-video-conf Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/web-ui-registration Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@guijun13 guijun13 changed the title Feat/room usercard menus feat: room usercard menus Jul 11, 2023
@guijun13 guijun13 changed the title feat: room usercard menus feat: room header and user card menus improvements Jul 11, 2023
gabriellsh and others added 4 commits August 10, 2023 15:05
…et.Chat into feat/room-usercard-menus

* 'feat/room-usercard-menus' of github.com:RocketChat/Rocket.Chat:
  fix: Performance issue on Messages.countByType aggregation (#30062)
  chore:  split fuselage js/css (#30039)
  test: migrate test/unit/client/view to jest (#29992)
  chore: Adjust mocha assertions (#30052)
  fix: Performance issue on Engagement Dashboard aggregation (#30022)
  regression: Change header buttons location on `GroupPage` (#30042)
  regression: Sidebar missing default width (#30043)
  chore: high-contrast button-primary colors (#30036)
  fix: user creation using ADMIN_* variables (#30015)
  fix: Deleted DM rooms can't be closed (#29984)
gabriellsh
gabriellsh previously approved these changes Aug 14, 2023
Copy link
Member

@gabriellsh gabriellsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Aug 18, 2023
@jessicaschelly jessicaschelly removed the stat: ready to merge PR tested and approved waiting for merge label Aug 18, 2023
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Aug 18, 2023
@scuciatto scuciatto removed the request for review from yash-rajpal August 18, 2023 13:51
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Aug 18, 2023
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Aug 18, 2023
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Aug 18, 2023
@kodiakhq kodiakhq bot merged commit a08006c into develop Aug 18, 2023
40 checks passed
@kodiakhq kodiakhq bot deleted the feat/room-usercard-menus branch August 18, 2023 16:26
gabriellsh added a commit that referenced this pull request Aug 21, 2023
…unreadMark

* 'develop' of github.com:RocketChat/Rocket.Chat:
  chore(deps): bump supercharge/mongodb-github-action from 1.9.0 to 1.10.0 (#30029)
  chore: convert push notifications code to typescript (#30108)
  refactor: Convert Omnichannel `helpers` file to TS (#29656)
  fix: Avoid blank spaces being sent as comment when comment is required (#29868)
  regression: add message id back on triggerActionButtonAction (#30120)
  chore: Initial a11y tweaks (#30119)
  fix: login blocked after block time (#30018)
  refactor: User forms to TS and replace `useForm` in favor of RHF (#30035)
  chore: codeBlock theme colors (#30038)
  feat: add sections to room header and user infos menus with menuV2 (#29780)
  fix: Keep embedded layout as true once set (#30087)
  fix: Issues with livechat message parsing (#30086)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants