-
Notifications
You must be signed in to change notification settings - Fork 10.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add sections to room header and user infos menus with menuV2 #29780
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 794b904 The changes in this PR will be included in the next version bump. This PR includes changesets to release 29 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
guijun13
changed the title
feat: room usercard menus
feat: room header and user card menus improvements
Jul 11, 2023
…et.Chat into feat/room-usercard-menus * 'feat/room-usercard-menus' of github.com:RocketChat/Rocket.Chat: fix: Performance issue on Messages.countByType aggregation (#30062) chore: split fuselage js/css (#30039) test: migrate test/unit/client/view to jest (#29992) chore: Adjust mocha assertions (#30052) fix: Performance issue on Engagement Dashboard aggregation (#30022) regression: Change header buttons location on `GroupPage` (#30042) regression: Sidebar missing default width (#30043) chore: high-contrast button-primary colors (#30036) fix: user creation using ADMIN_* variables (#30015) fix: Deleted DM rooms can't be closed (#29984)
gabriellsh
previously approved these changes
Aug 14, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
gabriellsh
approved these changes
Aug 17, 2023
dionisio-bot
bot
added
stat: ready to merge
PR tested and approved waiting for merge
and removed
stat: needs QA
labels
Aug 18, 2023
jessicaschelly
removed
the
stat: ready to merge
PR tested and approved waiting for merge
label
Aug 18, 2023
dionisio-bot
bot
added
the
stat: ready to merge
PR tested and approved waiting for merge
label
Aug 18, 2023
dionisio-bot
bot
added
stat: ready to merge
PR tested and approved waiting for merge
and removed
stat: ready to merge
PR tested and approved waiting for merge
labels
Aug 18, 2023
dionisio-bot
bot
added
stat: ready to merge
PR tested and approved waiting for merge
and removed
stat: ready to merge
PR tested and approved waiting for merge
labels
Aug 18, 2023
dionisio-bot
bot
added
stat: ready to merge
PR tested and approved waiting for merge
and removed
stat: ready to merge
PR tested and approved waiting for merge
labels
Aug 18, 2023
tassoevan
pushed a commit
that referenced
this pull request
Aug 19, 2023
…29780) Co-authored-by: gabriellsh <[email protected]>
gabriellsh
added a commit
that referenced
this pull request
Aug 21, 2023
…unreadMark * 'develop' of github.com:RocketChat/Rocket.Chat: chore(deps): bump supercharge/mongodb-github-action from 1.9.0 to 1.10.0 (#30029) chore: convert push notifications code to typescript (#30108) refactor: Convert Omnichannel `helpers` file to TS (#29656) fix: Avoid blank spaces being sent as comment when comment is required (#29868) regression: add message id back on triggerActionButtonAction (#30120) chore: Initial a11y tweaks (#30119) fix: login blocked after block time (#30018) refactor: User forms to TS and replace `useForm` in favor of RHF (#30035) chore: codeBlock theme colors (#30038) feat: add sections to room header and user infos menus with menuV2 (#29780) fix: Keep embedded layout as true once set (#30087) fix: Issues with livechat message parsing (#30086)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Modified
menus to menuV2 implementation to separate the items into sections
Room header
/views/room/Header/RoomToolbox/RoomToolbox.tsx
User card
/views/room/UserCard/UserCardWithData.tsx
User info
/views/room/contextualBar/UserInfo/UserInfoActions.tsx
User menu on members list
apps/meteor/client/views/room/contextualBar/RoomMembers/RoomMembersActions.tsx
Issue(s)
Closes #25147
Steps to test or reproduce
Further comments
https://rocketchat.atlassian.net/browse/TC-811